Feature Request:Boost By Gear enabled in Open Loop

[jackscr12]

I tried to do this myself but messed it up so am requesting the help of brighter minds to make Boost by Gear be available with Open Loop Boost control as well . Closed loop is great and all but not everyone wants to spends hours wasting gas to tune the PID when open loop is already set up and working great but would benefit from the option to reduce boost in lower gears.
Thank you.

[shiznit304]

Sure i can give it a shot. i have no way of testing it but sounds like fun

[shiznit304]

@jackscr12 https://github.com/shiznit304/speeduino/tree/boostByGearOpenLoop
go ahead and give it a shot. lmk if it works then i'll send it up the chain

[jackscr12]

Hmm seem to get this error while compiling
board_avr2560.h:23:21: fatal error: TimeLib.h: No such file or directory

#define RTC_LIB_H <TimeLib.h>

[shiznit304]

update your libraries

[jackscr12]

I managed to upload the firmware but after setting everything up engine cranks but does not start... I get rpm read-out but the injectors are not triggered.Tried several times even setting up the tune from scratch but the same thing...
I will mod my current firmware with your changes and try that way...maybe there is something in the latest master code that is not agreeing with my setup.

[shiznit304]

what firmware are you coming from?

[jackscr12]

I'm using the master from september 14th

[jackscr12]

Modded my current firmware and it starts fine so will test it further in a couple of hours and I'll report back.

[jackscr12]

Went for a drive and boost duty stayed at 0 whatever gear or Rpm I was at. One time it went to 1% Duty in 5th gear for 0.6s at initial tip in. Gears are being detected fine and so is VSS.

[shiznit304]

Did you try the different modes of boost by gear

…

On Thu, Oct 28, 2021 at 12:15 PM jackscr12 ***@***.***> wrote: Went for a drive and boost duty stayed at 0 whatever gear or Rpm I was at. One time it went to 1% Duty in 5th gear for 0.6s at initial tip in. Gear are being detected fine and so is VSS. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#695 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO6IHZGGWHXHIWWJ6QIGUF3UJGHL7ANCNFSM5G2EXZMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[jackscr12]

I only tried multiplied . Ran out of time today. will test more tomorrow.

[jackscr12]

Ok tried Fixed limit as well and still 0 boost duty, when boost by gear is off it works normal.

[shiznit304]

@DylanRooijakkers can you help code boost by gear but for open loop

[shiznit304]

@jackscr12 ok i pushed another update to the branch. try testing that

[jackscr12]

ok so went out again and partial success :) , constant limit works great but multiplied gives 100% duty irrespective of table duty or gear or gear %.

[DylanRooijakkers]

@DylanRooijakkers can you help code boost by gear but for open loop

Hello @shiznit304, I would very much like to expand the functionality of this feature, but I am currently busy studying for exams this week and the week after. I think I will have time from the 10th of November onwards. If there are any questions don't hesitate to ask. Cheers, Dylan

[jackscr12]

Went out to experiment again with multiplied , with 2% gear and 16% duty in the duty table I get 16% total duty in the logs. Where as before I used 70% in gear and 50% duty in the table and got 100% duty in the logs. So the multiplication algorithm is wonky somehow

[shiznit304]

what if you do 100% gear, at whatever duty cycle, do you still get the duty cycle value?

[jackscr12]

100% gear gives 100% duty, it's very weird how it behaves for example 30% gear and 46% duty in table gave me 34% actual duty , but if the table duty is 50% it goes to 100% actual duty in 5th gear , but I set 10% and than 20% in second gear and 36% table and it gave me 100% actual ,

[shiznit304]

@DylanRooijakkers wanna give it a shot

[shiznit304]

this can be closed @jackscr12