TS_CommandButtonHandler

[smb29]

TS_CommandButtonHandler
Can someone modify it, to have knock control from TS?

[Autohome2]

What is it exactly you want this button to do?

[smb29]

#764 (comment)

[FazxFi]

Did you mean the knock setting window or something else
#764 (comment)

[smb29]

I want something similar to the Knock settings window.
I think it would be a good thing for the community

[pazi88]

Creating knock setting window to TS is not big task and to be honest, there is already knock settings for Speeduino, but it's hidden. Reason being that there is not really any knock sensing done in Speeduino code. I think it will come with speedyknock in future.

[smb29]

well, if it's not a big deal, why don't you do it, instead of announcing it?
I know there are 241 mentions of Knock in the code, I even have some uncommented.
But, still, there is no trace in TS of Knock sensor. Not even on the programmable outputs

[pazi88]

I mean for the TS GUI. In actual FW it's huge job. And yes it's mostly not done in the FW.

[smb29]

I only ask that the TS GUI be modified

[pazi88]

I only ask that the TS GUI be modified

But you can't do anything with it, so what is the point?

[smb29]

have at least the option in TS of Knock

[pazi88]

have at least the option in TS of Knock

Yes, but as is, it doesn't do anything. You first would need to code the features to the FW, to be able to use any of that.

[smb29]

have at least the option in TS of Knock

Yes, but as is, it doesn't do anything. You first would need to code the features to the FW, to be able to use any of that.

so, everything is encoded in FW, (as far as Knock is concerned)
It does not even serve to assign an analog input in TS?

Just to clarify

[smb29]

Thanks

[smb29]

https://user-images.githubusercontent.com/62686180/148832992-983b5952-f7b2-41ec-a2dd-1d442a765278.png

How did this user do it?

[smb29]

https://user-images.githubusercontent.com/62686180/148832992-983b5952-f7b2-41ec-a2dd-1d442a765278.png

How did this user do it?

[pazi88]

have at least the option in TS of Knock

Yes, but as is, it doesn't do anything. You first would need to code the features to the FW, to be able to use any of that.

so, everything is encoded in FW, (as far as Knock is concerned) It does not even serve to assign an analog input in TS?

Just to clarify

Nothing is really done in FW. Just some reservations for settings etc. you can see that gui TS, by uncommenting it in ini. But don't expect anything to work.

[smb29]

Ok,
just to finish and not bother more.
From where you have access to the graphical user interface, in TS?

Thank you for your patience passi

[FazxFi]

You need to edit one of the file, just one line.

the easier one is just to edit the mainController.ini , in the TunerStudio folder for your tune file, went you update the FW it gonna change back to the current FW.

this one you need somekind of a text editor, notepad can be use.

first step is to open up your TS and your project you want to edit.
next is to click the "File" menu > Vehicle Project > Show Project Folder.

Its gonna open your file explore, now click the -projectCfg
there you can see the mainController.ini, now if you have something like notepad++ or something along the line, you need to right-click and choose the editor,
if you not have it, just double-click on it.

Its gonna open notepad,
now press "Ctrl + F" to find the line you want to edit, in this case its > KnockSettings <

now the last part, you just need to uncomment the line by deleting the " ; " sign,
and save the file, relaunch the TS and you can find it in " Spark " menu.

[smb29]

good, very kind

[smb29]

It's a shame, it can't be done forever

[mike501]

Im sure it will be done once the hardware / firmware is ready for general release. Please remember, this isn't generally released yet so you are taking on experimental software which may have defects. Any support you get is because we're all nice people and not guaranteed, ideally you should be prepared to support this yourself without anyone's assistance.

…

On Tue, 7 Jun 2022, 16:07 smb29, ***@***.***> wrote: It's a shame, it can't be done forever — Reply to this email directly, view it on GitHub <#863 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AONMGMBDSPZV7AEKUOTTZOLVN5QTDANCNFSM5X4AOH6Q> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[smb29]

Ok thanks I get it