Ensure 3.5 compatibility #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like Python 3.5 requires the module names to be dotted. Otherwise, it throws an error
```
...
from Porter import Porter
ImportError: No module named 'Porter'
```
|
Hello @JasonKessler, thanks for the hint. Seriously I'm surprised about this error, because all tests passed successfully: Before the next release/update I will test this issue in a local test environment. Because of that I keep this issue and pull request open. Happy coding, |
|
Thanks, Darius. It surprised me as well. It's possible it's just a quirk of my Anaconda 3.5 environment. |
|
Thanks @JasonKessler for your support! Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Python 3.5 requires the module names to be dotted. Otherwise, it throws an error