First pass at purifying the universal model #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Component listening is now handled by component registry. Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
lacasseio
force-pushed
the
lacasseio/model-core-test-new-entity
branch
from
e4fd935
to
65e3e96
Compare
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Signed-off-by: Daniel Lacasse <daniel@nokee.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The universal model is a great experiment so far. Unfortunately, it started from the software model and evolved toward an ECS design. Because of that, we have a bit of legacy in the code, which makes it harder to evolve and be efficient with it. Those next few PRs in that realm aim to purify the universal model into a layered ECS design. At its core, it should be Gradleless and deal only with entity-component-system. The layers above would introduce observability over component change, helper for building entities, and dynamic class generation. For example, we should consider component values to be fixed or provided (Gradle provider) because of Gradle. However, coding using the universal model should not rely on the provided value in the components. It should strictly be a way to provide a value + implicit dependencies + source.
This first step chips away the component registry from the model node.