Skip to content

Commit

Permalink
Additional fix to installer CSR signername and webhook
Browse files Browse the repository at this point in the history
It seems that including the signerName in RBAC is optional in 1.17
(and before?), but required as of 1.18.

Including signerName in the CSR itself, is optional in 1.18 but
NOT supported in 1.17 or earlier.

Hence, removing signerName from the CSR creation again. This may need
to be revisited later.
  • Loading branch information
carstenkoester committed May 15, 2020
1 parent 707cc96 commit a8f276f
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ spec:
groups:
- system:authenticated
request: $(cat ${tmpdir}/server.csr | base64 | tr -d '\n')
signerName: kubernetes.io/legacy-unknown
usages:
- digital signature
- key encipherment
Expand Down

0 comments on commit a8f276f

Please sign in to comment.