DANM 4.0 EP5: Adapting netwatcher to create VLAN and VxLAN interfaces for all APIs #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetWatcher will hold 3 of them from now on: DanmNet, TenantNetwork, and ClusterNetwork. It does not matter which API is getting modified, NetWatcher will handle them the exact same way.
Levovar
force-pushed
the
netwatcher_fourdoto
branch
15 times, most recently
from
8dc2dce
to
78a2380
Compare
1: Looks like we are patching VLAN and VxLAN IDs as string for TenantNetworks.
This resulted in netwatcher not being able to handle host interfaces, as decoding failed.
We have defined "value" in the Patch struct as RawMessage, which implicitly resulted in always creating "string" patches.
Changed the type to "interface{}" to mimic the official, upstream type, and let json.Marshal take care of creating the appropriate byte[] representation.
2: For some reason ClusterNetworks and TenantNetworks Informers complain during DELETE... but not DanmNet Informer.
Trying to use separate clients and factories per API, maybe it is a multi-treading issue?
Update: turned out these items are tombstone items! We need to handle them gracefully, they might hold our objects.
3: We also unfortunetaly can't avoid separate handlers for each API due to static type correctness.
4: We need to make sure that we only try to create and start an Informer, if its respective API is present in the cluster.
We solve this by doing a "List" first, and only create the Informer if listing was successful.
5: During initial sycnhing TN and CN endpoints received DN objects for some reason
Turns out Informers List during synching. Changing CN and TN List struct to contain the right type solved the issue.
Levovar
force-pushed
the
netwatcher_fourdoto
branch
from
78a2380
to
383e5e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary is reworked to be able to hold, and run more than one Controllers/Informers.
NetWatcher will hold 3 of them from now on: DanmNet, TenantNetwork, and ClusterNetwork.
It does not matter which API is getting modified, NetWatcher will handle them the exact same way.