fix: fix types for addEventListener and removeEventListener (#61)

nolanlawson · Nov 3, 2020 · f6b3d83 · f6b3d83
1 parent 253e982
commit f6b3d83
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/types/picker.ts b/src/types/picker.ts
@@ -28,15 +28,13 @@ export default class Picker extends HTMLElement {
     super()
   }
 
-  // Adding types for addEventListener is hard... I basically just copy-pasted this from lib.dom.d.ts. Not sure
-  // Why I need the @ts-ignore
-  addEventListener<K extends keyof EmojiPickerEventMap>(type: K, listener: (this: TextTrackCue, ev: EmojiPickerEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void
-  // @ts-ignore
-  addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void
+  addEventListener<K extends keyof EmojiPickerEventMap>(type: K, listener: (this: Picker, ev: EmojiPickerEventMap[K]) => any, options?: boolean | AddEventListenerOptions) {
+    super.addEventListener(type, listener, options);
+  }
 
-  removeEventListener<K extends keyof EmojiPickerEventMap>(type: K, listener: (this: TextTrackCue, ev: EmojiPickerEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void
-  // @ts-ignore
-  removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void
+  removeEventListener<K extends keyof EmojiPickerEventMap>(type: K, listener: (this: Picker, ev: EmojiPickerEventMap[K]) => any, options?: boolean | EventListenerOptions) {
+    super.removeEventListener(type, listener, options);
+  }
 }
 
 // see https://justinfagnani.com/2019/11/01/how-to-publish-web-components-to-npm/