Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing category emoji size independent of other emoji size #133

Closed
nolanlawson opened this issue May 29, 2021 · 7 comments · Fixed by #137
Closed

Allow changing category emoji size independent of other emoji size #133

nolanlawson opened this issue May 29, 2021 · 7 comments · Fixed by #137
Labels
enhancement New feature or request

Comments

@nolanlawson
Copy link
Owner

Given #10 (comment), this seems like a sensible feature.

@nolanlawson nolanlawson added the enhancement New feature or request label May 29, 2021
@ericaig
Copy link

ericaig commented May 31, 2021

Hello Nolan, it's great you've made plans to add this feature to this package.

While I was trying to adapt the --emoji-size to best fit my design I found this out:
Simulator Screen Shot - iPhone 8 Plus - 2021-05-31 at 08 41 18

Whenever you increase the size of the emoji (categories) the transform style on the indicator element miscalculates the currently selected category. In the above screenshot I have the ⛔️ selected.

Thank you for dedicating your time to give us this simple and complete emoji-picker

@nolanlawson
Copy link
Owner Author

@ericaig It appears that this only happens if the category emoji overflow horizontally (notice that the flag emoji is cut off).

Ideally with some way to control the emoji category size separately from the other ones, you should be able to have it not overflow. 🙂

@ericaig
Copy link

ericaig commented May 31, 2021

@nolanlawson Exactly. Leaving the categories size to it's default size solves both topics (categories dedicated size variable and horizontal scroll) 👌🏾

@ericaig
Copy link

ericaig commented May 31, 2021

If you need help with this. I'll be glad to chip in. It would be my first time contributing to a public package (code-wise) but I know how it works 😊

@nolanlawson
Copy link
Owner Author

Ah sorry, I got around to it. :) ^

nolanlawson added a commit that referenced this issue May 31, 2021
* feat: allow styling category emoji separately

fixes #133

* fix: tweak css to avoid descendant selector

* docs: fix typo

* docs: rebuild

* docs: fix another typo
@nolanlawson
Copy link
Owner Author

Release in 1.5.0

@ericaig
Copy link

ericaig commented Jun 1, 2021

@nolanlawson Perfect... I'll update it on my project now.. Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants