Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to custom favorites emojis #205

Closed
yravid opened this issue Aug 9, 2021 · 2 comments · Fixed by #210
Closed

Option to custom favorites emojis #205

yravid opened this issue Aug 9, 2021 · 2 comments · Fixed by #210
Labels
bug Something isn't working

Comments

@yravid
Copy link

yravid commented Aug 9, 2021

Hi,
There is a behavior which I find odd when using the picker especially when clicking an emoji from the favorites list,
Clicking on an emoji (which is not the first one) may change the favorites list order and when clicking more than once it may be replaced by another emoji and cause confusion,
Illustration:
Screen Recording 2021-08-09 at 10 23 21
I think it would be useful to have an option to 'freeze' the favorites list and only change it before/after mounting.

Love your library! 🥇
Thanks,
Yahav

@nolanlawson
Copy link
Owner

Hmmmm, this is a good point. I had observed this behavior but it hadn't occurred to me that it might be a problem.

I think there's a case to be made that "freezing" should just be the default behavior. I can't see a case where you'd want the favorites list to update while the picker is mounted. So maybe the favorites should be frozen throughout the entire picker lifecycle, and only updated in the connectedCallback phase.

@nolanlawson nolanlawson added the bug Something isn't working label Aug 13, 2021
@nolanlawson
Copy link
Owner

BTW can you describe your use case a bit? I had assumed that most usages are:

  1. Load the picker
  2. The user clicks an emoji
  3. Close the picker

... in which case nobody would notice the favorites moving around. I'm curious to know if your use case is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants