Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update favorites only on mount #210

Merged
merged 1 commit into from Aug 13, 2021
Merged

fix: update favorites only on mount #210

merged 1 commit into from Aug 13, 2021

Conversation

nolanlawson
Copy link
Owner

Fixes #205

I can't really think of a strong reason to update the favorites immediately. The favorites are an enhancement; they aren't a critical part of the experience. And it's confusing to see them move around.

If people want these to update, they can create a new <emoji-picker> element or remove it from the DOM and re-insert it into the DOM. This seems reasonable to me as most pickers I imagine will be created on-demand and dismissed as soon as the user picks an emoji. If not, the favorites will update when the page is refreshed.

@github-actions
Copy link

github-actions bot commented Aug 13, 2021

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-first-load: unsure 🔍 -7% - +8% (-6.78ms - +7.54ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -5% - +8% (-4.49ms - +8.22ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
89.75ms - 99.73ms-unsure 🔍
-7% - +8%
-6.78ms - +7.54ms
tip-of-tree
tip-of-tree
89.23ms - 99.50msunsure 🔍
-8% - +7%
-7.54ms - +6.78ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
96.94ms - 105.14ms-unsure 🔍
-5% - +8%
-4.49ms - +8.22ms
tip-of-tree
tip-of-tree
94.32ms - 104.03msunsure 🔍
-8% - +4%
-8.22ms - +4.49ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

Size Change: -10 B (0%)

Total Size: 41.5 kB

Filename Size Change
./bundle.js 41.5 kB -10 B (0%)

compressed-size-action

@nolanlawson nolanlawson merged commit 567da73 into master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to custom favorites emojis
1 participant