fix: update favorites only on mount #210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205
I can't really think of a strong reason to update the favorites immediately. The favorites are an enhancement; they aren't a critical part of the experience. And it's confusing to see them move around.
If people want these to update, they can create a new
<emoji-picker>
element or remove it from the DOM and re-insert it into the DOM. This seems reasonable to me as most pickers I imagine will be created on-demand and dismissed as soon as the user picks an emoji. If not, the favorites will update when the page is refreshed.