Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in the demo #276

Closed
guidouil opened this issue Apr 15, 2022 · 1 comment · Fixed by #277
Closed

Bug in the demo #276

guidouil opened this issue Apr 15, 2022 · 1 comment · Fixed by #277
Labels
bug Something isn't working

Comments

@guidouil
Copy link

On the Demo website

If you check "Custom emoji" then click on the flag tab then uncheck "Custom emoji"
The emoji picker freeze with an error in the console :

picker.js:843 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'id')
@nolanlawson
Copy link
Owner

Thank you, confirmed. Looks like a bug when dynamically adding or remove custom emoji.

@nolanlawson nolanlawson added the bug Something isn't working label Apr 15, 2022
nolanlawson added a commit that referenced this issue Apr 16, 2022
@nolanlawson
fix: fix category with unsetting customEmoji
1373528 
Fixes #276
@nolanlawson nolanlawson mentioned this issue Apr 16, 2022
Merged
nolanlawson added a commit that referenced this issue Apr 16, 2022
@nolanlawson
fix: fix category with unsetting customEmoji (#277)
3601f79 
Fixes #276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix category when unsetting customEmoji nolanlawson/emoji-picker-element
2 participants
@nolanlawson @guidouil