Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscores in when hovering over emoji in the picker #366

Closed
rch77 opened this issue Oct 4, 2023 · 3 comments · Fixed by #369
Closed

Underscores in when hovering over emoji in the picker #366

rch77 opened this issue Oct 4, 2023 · 3 comments · Fixed by #369
Labels
enhancement New feature or request

Comments

@rch77
Copy link

rch77 commented Oct 4, 2023

Is there way to get rid of the underscores in the title and aria-label? It looks odd.
I think the picker uses shortcodes from the db while it should use annotation.

@nolanlawson
Copy link
Owner

Thanks for opening the issue! Could you be more specific about what you're looking for? Do you want to:

  1. Disable the title (hover) entirely?
  2. Replace the underscores with a space character (or something)?

Right now this data comes directly from emoji-picker-element-data, which gets the shortcodes directly from emojibase-data, but maybe we can offer an option to do something else.

@nolanlawson nolanlawson added the enhancement New feature or request label Oct 8, 2023
@rch77
Copy link
Author

rch77 commented Oct 8, 2023

Thank you for the response. I would like the title (hover) to come from the annotation field in the db. I.e. without underscores in human readable form so that somebody hovering over it would be able to read it as descriptive English text not some code. As in the screenshot below, "cloud with lightning and rain" instead of "stormy, thunder_cloud_and_rain" it uses now.
image
Some of the shortcodes values in the db are not even human readable. E.g. shortcodes:0:"ja_here" with annotation:"Japanese “here” button".

@nolanlawson
Copy link
Owner

Yeah this is a good point – the shortcode hover was mostly designed for usecases like a social media app where you might actually use the shortcodes and even memorize a few.

I'm totally fine with just making the default the annotation. If someone complains and wants the shortcode back, we can use that instead.

BTW this isn't really an integral part of the experience – you can only see it if you have a mouse or you're a screenreader user, e.g. sighted mobile users would never be able to see this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants