Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: wait for initial load in benchmarks #390

Merged
merged 1 commit into from Dec 11, 2023
Merged

perf: wait for initial load in benchmarks #390

merged 1 commit into from Dec 11, 2023

Conversation

nolanlawson
Copy link
Owner

Messed up #389 a bit, should wait for the picker to fully load before running any benchmarks.

Copy link

github-actions bot commented Dec 11, 2023

📊 Tachometer Benchmark Results

Summary

benchmark-total

  • emoji-picker-element-change-tab: unsure 🔍 -2% - +2% (-1.03ms - +0.85ms)
    this-change vs tip-of-tree
  • emoji-picker-element-database-interactions: unsure 🔍 -4% - +3% (-3.87ms - +3.00ms)
    this-change vs tip-of-tree
  • emoji-picker-element-first-load: unsure 🔍 -8% - +2% (-4.01ms - +1.21ms)
    this-change vs tip-of-tree
  • emoji-picker-element-second-load: unsure 🔍 -1% - +1% (-0.59ms - +0.60ms)
    this-change vs tip-of-tree

Results

emoji-picker-element-change-tab
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
50.69ms - 51.57ms-unsure 🔍
-2% - +2%
-1.03ms - +0.85ms
tip-of-tree
tip-of-tree
50.39ms - 52.05msunsure 🔍
-2% - +2%
-0.85ms - +1.03ms
-
emoji-picker-element-database-interactions
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
105.04ms - 109.46ms-unsure 🔍
-4% - +3%
-3.87ms - +3.00ms
tip-of-tree
tip-of-tree
105.05ms - 110.31msunsure 🔍
-3% - +4%
-3.00ms - +3.87ms
-
emoji-picker-element-first-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
45.42ms - 48.65ms-unsure 🔍
-8% - +2%
-4.01ms - +1.21ms
tip-of-tree
tip-of-tree
46.38ms - 50.48msunsure 🔍
-3% - +9%
-1.21ms - +4.01ms
-
emoji-picker-element-second-load
VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
this-change
42.57ms - 43.33ms-unsure 🔍
-1% - +1%
-0.59ms - +0.60ms
tip-of-tree
tip-of-tree
42.49ms - 43.40msunsure 🔍
-1% - +1%
-0.60ms - +0.59ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link

Size Change: 0 B

Total Size: 42.8 kB

ℹ️ View Unchanged
Filename Size
./bundle.js 42.8 kB

compressed-size-action

@nolanlawson nolanlawson merged commit 8a4e4d6 into master Dec 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant