replace electron-rebuild with electron-builder #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to revive this repo by replacing electron-rebuild with electron-builder. Among many features electron-builder handles native dependencies well.
I was able to compile the app for Windows and macOS. IndexedDB, WebSQL, LevelDB, and node-websql (SQLite) all working.
When running the app with
npm startthe LevelDB folder and sqlite file were stored in the project directory which is fine, but when compiled i'm not quite sure where they were stored or if it was being stored at all.I found out that if you add a file path to the PouchDB constructor it will store the databases in that location. I can't find any mention of this being part of the PouchDB API, but its working.