Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark calculations #14

Merged
merged 2 commits into from
Sep 24, 2016
Merged

Conversation

mlrawlings
Copy link
Contributor

@mlrawlings mlrawlings commented Sep 20, 2016

This fixes #13 - the minified difference is being divided by the unminified/unoptimized time when it should be the minified/unoptimized time. This leads to incorrect results in the improvement column for all minified times. (looks like a copy/paste error)

I didn't actually re-run the benchmarks, I simply recalculated values from the table - because of this there is some rounding error, but the overall results should be more accurate than they were.

If you choose to just fix the benchmark and regenerate things, that's fine too.

@nolanlawson
Copy link
Owner

Thank you – this is why I do things out in the open: so that people can check my work and correct any errors. 😃

I'm not sure why the opt vs unopt improvements were slightly off as well, but I'll need to check my code and see if there was a rounding error or something. In any case, thank you very much for the fix – I checked manually and these improvement numbers are indeed correct. Cheers!

@nolanlawson nolanlawson merged commit 07a663a into nolanlawson:master Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Your math is wrong
2 participants