New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esc key should dismiss the tooltip #1267

Closed

nolanlawson opened this issue Jun 4, 2019 · 0 comments · Fixed by #1268

Labels

accessibility bug

Owner

nolanlawson commented Jun 4, 2019

Just realized that this is the one thing that the WAI ARIA Practices actually agrees on for tooltips, and I forgot to add it: https://www.w3.org/TR/wai-aria-practices-1.1/#tooltip

nolanlawson added bug accessibility labels

nolanlawson added a commit that referenced this issue


          fix: Esc key dismisses tooltip

2a102f2

fixes #1267

nolanlawson mentioned this issue

fix: Esc key dismisses tooltip #1268

Merged

nolanlawson closed this as completed in #1268

nolanlawson added a commit that referenced this issue


          fix: Esc key dismisses tooltip (#1268)

c397753

fixes #1267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment