Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click notification should open app and corresponding post #1365

Closed
pwFoo opened this issue Jul 30, 2019 · 6 comments · Fixed by #1378
Closed

Click notification should open app and corresponding post #1365

pwFoo opened this issue Jul 30, 2019 · 6 comments · Fixed by #1378
Labels
bug Something isn't working

Comments

@pwFoo
Copy link

pwFoo commented Jul 30, 2019

If I click notification it doesn't open the app in chrome for android. Maybe it works with a open tab in background, but it should open app ("add to homescreen") or browser if no tab / app in background?

@nolanlawson
Copy link
Owner

Hmmm this is interesting. So you choose "add to homescreen" in Chrome, and then you enabled notifications, but then when you click the notification, it opens the app? Or the browser?

Also, is this regular Chrome with Google Play Services, or is it LineageOS with Chromium or something similar?

@nolanlawson nolanlawson added the bug Something isn't working label Jul 31, 2019
@pwFoo
Copy link
Author

pwFoo commented Jul 31, 2019

  • Chrome for Android (PlayStore)
  • Android 9 (OxýgenOS 9.0.7)

If I click the notification nothing happens. Notification is still shown.
I don't know if it happens with desktop pc (Win10, Chrome). Most of the time I use it mobile (OnePlus 5).

@pwFoo
Copy link
Author

pwFoo commented Jul 31, 2019

Updated pinafore to latest / 1.11.6.

sorin-davidoi added a commit to sorin-davidoi/pinafore that referenced this issue Aug 7, 2019
If the notifications couldn't be fetched fallback to displaying all notifications (aligned with how the Mastodon Web UI [handles it](https://github.com/tootsuite/mastodon/blob/master/app/javascript/mastodon/service_worker/web_push_notifications.js#L118)).

Might fix nolanlawson#1365.
nolanlawson pushed a commit that referenced this issue Aug 8, 2019
* fix(service-worker): Open notifications if no status

If the notifications couldn't be fetched fallback to displaying all notifications (aligned with how the Mastodon Web UI [handles it](https://github.com/tootsuite/mastodon/blob/master/app/javascript/mastodon/service_worker/web_push_notifications.js#L118)).

Might fix #1365.

* fix(service-worker): Use self
@pwFoo
Copy link
Author

pwFoo commented Aug 8, 2019

Hi @nolanlawson,
something different with the release v1.11.7 because my docker image build fails?

Step 7/19 : RUN VERSION=${VERSION:-$(curl --silent $REPO/releases/latest | sed 's#.*tag/\(.*\)\".*#\1#')};      echo $VERSION;  git checkout $VERSION
 ---> Running in 1f6a1ba179ac
v1.11.7
error: pathspec 'v1.11.7' did not match any file(s) known to git
The command '/bin/sh -c VERSION=${VERSION:-$(curl --silent $REPO/releases/latest | sed 's#.*tag/\(.*\)\".*#\1#')};      echo $VERSION;  git checkout $VERSION' returned a non-zero code: 1

Looks like v1.11.7 isn't available for checkout? v1.11.7 works fine with that line. Also tried to set VERSION to v1.11.6 and 1.11.7, but only the older one works.

@pwFoo
Copy link
Author

pwFoo commented Aug 8, 2019

Fixed!
Looks like a docker cache problem...

@pwFoo
Copy link
Author

pwFoo commented Aug 8, 2019

Hi @nolanlawson,

Dependent on notification type a retoot opens the app and correct post, but would it possible to remove a read notification from android task bar?
Notification about user favorite a toot don't open the app and also not closed after clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants