Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call revokeObjectURL on stale blurhash URLs #1402

Closed
nolanlawson opened this issue Aug 18, 2019 · 0 comments · Fixed by #1403
Closed

Call revokeObjectURL on stale blurhash URLs #1402

nolanlawson opened this issue Aug 18, 2019 · 0 comments · Fixed by #1403
Labels
performance Related to speed or responsiveness

Comments

@nolanlawson
Copy link
Owner

#1381

This will avoid a memory leak. (In theory – I'm not sure if browsers have some way to do this automatically or not. Although we shouldn't take the chance.)
@nolanlawson nolanlawson added the performance Related to speed or responsiveness label Aug 18, 2019
nolanlawson added a commit that referenced this issue Aug 18, 2019
@nolanlawson
perf: call revokeObjectURL() on stale blurhash blob URLs
b6ec2ef 
fixes #1402
@nolanlawson nolanlawson mentioned this issue Aug 18, 2019
Merged
nolanlawson added a commit that referenced this issue Aug 18, 2019
@nolanlawson
perf: call revokeObjectURL() on stale blurhash blob URLs (#1403)
009a511 
* perf: call revokeObjectURL() on stale blurhash blob URLs

fixes #1402

* add a test

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Related to speed or responsiveness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: call revokeObjectURL() on stale blurhash blob URLs nolanlawson/pinafore
1 participant
@nolanlawson