Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pleroma mentions and hashtags open in new window, not locally #832

Closed
nolanlawson opened this issue Dec 17, 2018 · 5 comments · Fixed by #1511
Closed

Pleroma mentions and hashtags open in new window, not locally #832

nolanlawson opened this issue Dec 17, 2018 · 5 comments · Fixed by #1511
Labels
bug Something isn't working compatibility Compat with Pleroma, glitch-soc, etc.

Comments

@nolanlawson
Copy link
Owner

When someone is mentioned in Pleroma, if you click the handle it will take you to their public profile, rather than the local one.

@nolanlawson nolanlawson added bug Something isn't working compatibility Compat with Pleroma, glitch-soc, etc. labels Dec 17, 2018
@nolanlawson
Copy link
Owner Author

It seems that Pleroma does not add the mention class to mentions, which is what I'm looking for. Unfortunately the only alternative is to traverse all anchor tags and check their href.

@nolanlawson
Copy link
Owner Author

It seems this is also true for hashtags - there is no hashtag class.

@nolanlawson
Copy link
Owner Author

Looks like for hashtags, Pleroma does not provide any indication that there is something special about hashtag links. For mentions at least, there is the status.mentions array so we can infer it. But for hashtags there is nothing.

I feel that Pleroma should add these tags, since otherwise it's really tricky to process these anchors. Especially for hashtags, I don't like relying on the convention of (/tag/foo), since a site could spoof that by adding /tag/foo itself (and then you'd have to rely on the convention of the hashtag starting with a #... conventions on conventions).

@nolanlawson
Copy link
Owner Author

I filed a bug on Pleroma, but then the Pleroma GitLab crashed, so I can't link to it. 😕

@nolanlawson
Copy link
Owner Author

@nolanlawson nolanlawson changed the title Pleroma account mentions open in new window, not locally Pleroma mentions and hashtags open in new window, not locally Dec 17, 2018
nolanlawson added a commit that referenced this issue Sep 22, 2019
nolanlawson added a commit that referenced this issue Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Compat with Pleroma, glitch-soc, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant