New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boost icon looks misaligned from other icons #916
Comments
Thanks for reporting. You can hover over the icons to see a tooltip showing what the state is; this tooltip is the same as the aria label that's provided to screenreaders. Empty star would be tricky because I believe this is not provided by font awesome, plus it would conflict with the current animation. As for the boost button yes, fontawesome arguably should make it wider to match the other icons. This seems like a straightfoward fix assuming everything still lines up correctly. |
I just want to point out that they made it wider, in fact it's too wide and that's why it doesn't match. You can make the same change in the CSS as I did to compensate it (or I could try to send a PR if needed) |
Weird, but the icon is not a square even in the latest release of FontAwesome. Mind if I edit the Update: The icon itself is misaligned in the source svg file. And the shape's width exceeds 1792px, so the icon will be cropped if I just reduce the viewport size to 1792x1792. I'll just make a new icon and ask for feedback! |
@Heartade If you can find a way to fix the SVG directly then by all means, please feel free to open a PR. 🙂 I used font-awesome-svg-png for this, but it seems unmaintained. |
Hey!
I've always felt that something is off with "boost" icon and now I think I know the reason: it's smaller.
All icons are of the same width but because boost icon has different proportions it always seems smaller to me.
I would propose to increase the width of the boost icon to compensate it's aspect ratio:
I would also propose some non-color identification of boost/fav status. With star it's simple: empty and filled star. Boost icon would require much more creativity and I have no good ideas, maybe other folks do.
The text was updated successfully, but these errors were encountered: