Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost icon looks misaligned from other icons #916

Open
charlag opened this issue Jan 26, 2019 · 4 comments
Open

Boost icon looks misaligned from other icons #916

charlag opened this issue Jan 26, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@charlag
Copy link
Contributor

charlag commented Jan 26, 2019

Hey!
I've always felt that something is off with "boost" icon and now I think I know the reason: it's smaller.

screenshot from 2019-01-26 14-47-32

All icons are of the same width but because boost icon has different proportions it always seems smaller to me.
I would propose to increase the width of the boost icon to compensate it's aspect ratio:
screenshot from 2019-01-26 15-04-43

I would also propose some non-color identification of boost/fav status. With star it's simple: empty and filled star. Boost icon would require much more creativity and I have no good ideas, maybe other folks do.

@nolanlawson
Copy link
Owner

Thanks for reporting. You can hover over the icons to see a tooltip showing what the state is; this tooltip is the same as the aria label that's provided to screenreaders. Empty star would be tricky because I believe this is not provided by font awesome, plus it would conflict with the current animation.

As for the boost button yes, fontawesome arguably should make it wider to match the other icons. This seems like a straightfoward fix assuming everything still lines up correctly.

@nolanlawson nolanlawson added the bug Something isn't working label Jan 26, 2019
@charlag
Copy link
Contributor Author

charlag commented Jan 26, 2019

I just want to point out that they made it wider, in fact it's too wide and that's why it doesn't match. You can make the same change in the CSS as I did to compensate it (or I could try to send a PR if needed)

@nolanlawson nolanlawson changed the title Proposal: Improving status button icons Boost icon looks misaligned from other icons Mar 14, 2021
@Heartade
Copy link
Contributor

Heartade commented Dec 4, 2022

Weird, but the icon is not a square even in the latest release of FontAwesome. Mind if I edit the retweet.svg manually in the static directory and submit a PR?

Update: The icon itself is misaligned in the source svg file. And the shape's width exceeds 1792px, so the icon will be cropped if I just reduce the viewport size to 1792x1792. I'll just make a new icon and ask for feedback!

Heartade added a commit to Heartade/pinafore that referenced this issue Dec 4, 2022
@nolanlawson
Copy link
Owner

@Heartade If you can find a way to fix the SVG directly then by all means, please feel free to open a PR. 🙂

I used font-awesome-svg-png for this, but it seems unmaintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants