Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add legacy build #1502

Merged
merged 3 commits into from Sep 21, 2019
Merged

feat: add legacy build #1502

merged 3 commits into from Sep 21, 2019

Conversation

nolanlawson
Copy link
Owner

As an experiment (which I may eventually roll back), I would like to try to get Pinafore to run on KaiOS feature phones. Since KaiOS is roughly equivalent to Firefox 48, it doesn't have all the latest browser features. So I would like to have a special mode where I can build Pinafore for "legacy" browsers.

This adds:

LEGACY=1 yarn build

...which will output Pinafore in ES5 format with an extra polyfill (Intl) and some extra optimizations. Based on my testing so far, this should allow Pinafore to run on KaiOS phones (although it needs a lot more work to support the small screen size).

I also added some console.logs that I find useful for debugging.

@nolanlawson nolanlawson merged commit 6358af5 into master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant