fix: don't set aria-activedescendant immediately on autocomplete textarea #1513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing on NVDA on Windows on Chrome/Firefox/FirefoxDeveloperEdition and on VoiceOver on Safari macOS, I believe this is the best implementation.
This changes the code so that we don't set
aria-activedescendant
oraria-owns
until autocomplete results are available. We remove and add thearia-activedescendant
andaria-owns
attributes as the autocomplete results appear and disappear. This should make is so that thearia-hidden
element which is referenced byaria-activedescendant
/aria-owns
is not referenced until it's no longeraria-hidden
.@MarcoZehe I don't think I could reproduce the exact issue you describe in NVDA on Firefox Developer Edition, but I believe this fix is an improvement in VoiceOver on Safari at least. The best screenreader seems to be NVDA on Chrome, because the others have odd bugs:
dev.pinafore.social
and in this PR.I couldn't figure out how to solve either of these issues.