Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run tests on Mastodon v4 #2256

Merged
merged 4 commits into from
Dec 2, 2022
Merged

test: run tests on Mastodon v4 #2256

merged 4 commits into from
Dec 2, 2022

Conversation

nolanlawson
Copy link
Owner

No description provided.

@nolanlawson nolanlawson changed the title chore: chore: update tests to use Mastodon v4 chore: update tests to use Mastodon v4 Nov 25, 2022
@nolanlawson
Copy link
Owner Author

nolanlawson commented Nov 27, 2022

Since Mastodon 3.6, filters can contain multiple keywords and are matched server-side.

This is probably why the filter tests are busted. I'm using the old v1/ filtering API:

export function updateFilter (instanceName, accessToken, filter) {
const url = `${basename(instanceName)}/api/v1/filters/${filter.id}`
return put(url, filter, auth(accessToken), { timeout: WRITE_TIMEOUT })
}

There is also some client-side filtering; not sure how much Mastodon v3.6+ can do for us instead.

Also not sure how to support Mastodon v3.6+ plus older versions and other servers like Pleroma and Misskey. Might need some feature detection that falls back to client-side filtering.

@nolanlawson nolanlawson changed the title chore: update tests to use Mastodon v4 fix: support Mastodon v4 Nov 27, 2022
@nolanlawson
Copy link
Owner Author

OK so apparently the test failure is caused by a true Mastodon v4 bug: mastodon/mastodon#21965

Probably the long-term fix is #2265. For now we can just disable the test.

@nolanlawson nolanlawson changed the title fix: support Mastodon v4 test: run tests on Mastodon v4 Dec 2, 2022
@nolanlawson nolanlawson merged commit 6d6eb59 into master Dec 2, 2022
alice-werefox pushed a commit to alice-werefox/sema-werefox-cafe that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant