Explain how to use the buildCommand for internationalization #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
reviewed
Jan 8, 2023
docs/Internationalization.md
Outdated
| @@ -16,5 +16,11 @@ or | |||
|
|
|||
| LOCALE=fr yarn dev | |||
|
|
|||
| To host a localized version of Pinafore using Vercel, in the [vercel.json file](https://github.com/nolanlawson/pinafore/blob/master/vercel.json), replace the buildCommand value accordingly. | |||
There was a problem hiding this comment.
Rather than say "replace the buildCommand value accordingly," I think it would be more helpful to refer directly to the line of code:
Otherwise it's not necessarily clear what needs to be done.
nolanlawson
reviewed
Jan 8, 2023
docs/Internationalization.md
Outdated
| There is also an experimental `LOCALE_DIRECTION` environment variable for the direction (LTR versus RTL) which is | ||
| exposed to the source code while building. | ||
|
|
||
| To host a localized version of Pinafore using Vercel, in the [vercel.json file](https://github.com/nolanlawson/pinafore/blob/master/vercel.json), replace the buildCommand key accordingly. |
|
Hi @nolanlawson , I've addressed your comments. Please let me know if something is still needed. |
|
LGTM, I am just waiting for the build to be unbroken so I can merge PRs. #2349 |
|
Thanks for merging and for your suggestion. I didn"t know how to provide a link to a line in a file.Enviado desde mi iPhoneEl 9 ene 2023, a las 5:02, Nolan Lawson ***@***.***> escribió:
Merged #2344 into master.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
alice-werefox
pushed a commit
to alice-werefox/sema-werefox-cafe
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed this on PR #2329