disable manifest.json for iOS #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dang, it looks like this will only work if you clear the Safari data. Apparently the way Service Workers work on Safari is that it doesn't overwrite a 200 response with a 404 response, so the client just never sees the 404ing manifest.json. 😕 Clearing Safari data works, though. Add to homescreen causes the icon to just open in Safari. I guess this is better than nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #45
This PR UA sniffs for iOS devices and sends a 404 for
/manifest.json. It's an unfortunate workaround for this problem, but I've confirmed that it allows "add to homescreen" to work on iOS. When you tap the homescreen icon, it just opens Pinafore in Safari.