Bug Fixes #245
Merged
Bug Fixes #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
garrensmith
commented
Jan 25, 2017
garrensmith
commented
- fix regex with default index
- Add some skip tests where Mango and pouchdb-find differ
- Fixes for default inde
- Fixes for field that is defined in an index but has isn't a logical operator
nolanlawson
requested changes
Jan 25, 2017
| @@ -78,6 +82,10 @@ function rowFilter (doc, selector, inMemoryFields) { | |||
| }); | |||
| } | |||
|
|
|||
| function isDesignDoc (doc) { | |||
| return /_design/.test(doc._id); | |||
There was a problem hiding this comment.
should be /^_design\// to start searching at the beginning of the string and include the /
| @@ -131,6 +131,10 @@ function checkFieldsLogicallySound(indexFields, selector) { | |||
| var firstField = indexFields[0]; | |||
| var matcher = selector[firstField]; | |||
|
|
|||
| if (matcher === undefined) { | |||
There was a problem hiding this comment.
typeof matcher === 'undefined' is safer because some JS engines allow overwriting undefined (i.e. it's a variable not a keyword)
| }); | ||
| }); | ||
|
|
||
| it.skip('empty selector returns empty docs', function () { |
There was a problem hiding this comment.
did you mean to add a new skipped test?
There was a problem hiding this comment.
Yes I did mean to add this. I was going to fix it but I'm not sure if the issue is pouchdb-find or Mango. So I'm skipping it for now.
|
Fantastic, nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.