Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] RBAC for automatic legacy peering detection #95

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed

[PR] RBAC for automatic legacy peering detection #95

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive automation CI/CD: testing, linting, releasing automatically documentation Documentation improvements

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by nolar at 2019-06-02 03:17:07+00:00
Original URL: zalando-incubator/kopf#95
Merged by nolar at 2019-06-14 09:18:57+00:00

Issue : #12, #13, originally mentioned in #49 comments

Add the missing RBAC permissions for legacy CRD scanning in the documentation (deployment patterns, RBAC section).

Since CRD scanning is a cluster-scoped operation, and cluster-scoped RBAC is not always possible, make so that the "403 permission denied" response for CRDs is treated as the absence of CRD. It is currently only used for legacy peering CRD, and nothing else.

As part of that, in tests, also check for other typical statuses for all get/list API operations — via parametrization.

PS: The feature was introduced in the automatic peering/standalone mode discovery (#33 #38).

@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] RBAC for automatic legacy peering detection Aug 19, 2020
@kopf-archiver kopf-archiver bot added automation CI/CD: testing, linting, releasing automatically documentation Documentation improvements labels Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive automation CI/CD: testing, linting, releasing automatically documentation Documentation improvements
Projects
None yet
Development

No branches or pull requests

0 participants