Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] [GH-33] implement auto detection mode for peering. #38

Closed
kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Closed

[PR] [GH-33] implement auto detection mode for peering. #38

kopf-archiver bot opened this issue Aug 18, 2020 · 0 comments
Labels
archive enhancement New feature or request

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by psycho-ir at 2019-04-22 10:39:04+00:00
Original URL: zalando-incubator/kopf#38
Merged by nolar at 2019-04-24 15:56:01+00:00

Issue : #33 (only if appropriate)

nolar I will write the tests and document it once we agreed on the implementation.


Commented by nolar at 2019-04-22 19:24:22+00:00
 

psycho-ir PS: Also, feel free to remove the clutter from the PR body if you want. (I think, the PR template must be reduced to only an issue reference (it is mandatory), with no implicit structure. — Will do later.)


Commented by psycho-ir at 2019-04-22 20:05:40+00:00
 

I've tried it locally. There is a little bug with the ...cls(peering=None,... — crashes on start (see comments). Once fixed, it works nice in all modes, exactly as intended.

Would you like to extend the docs (docs/peering.rsthttps://kopf.readthedocs.io/en/latest/peering/) in this PR? Or I can do this in the following PRs, together with other peering doc changes.

Sure, I will extend the docs tomorrow and try to add some tests for it.


Commented by nolar at 2019-04-24 16:11:36+00:00
 

psycho-ir So, it is merged and released as kopf==0.9. Congratulation! And big thanks for your contribution!


Commented by psycho-ir at 2019-04-24 16:46:41+00:00
 

nolar yaaaaaay. what is the next milestone? Would be happy to contribute more in this project.


Commented by nolar at 2019-04-26 10:06:18+00:00
 

psycho-ir

Currently, the milestone 1 is this:

  • Tests, tests, tests — to bring the repo to a healthy state, so that I am not afraid to introduce new changes without breaking things. 90% of them are done, just in the PRs or in my local branches waiting for some PRs to be merged.

  • Silent spies on the events (see Silent handlers (spies) #30 ) — to react to the events in pods, persistent volume claims, etc, without storing the handler status. Already implemented in my local branch, waiting for the tests.

  • Finish the tutorial in the docs, so that the kind: EphemeralVolumeClaim becomes a real example operator in its own repo, uploaded to the DockerHub, etc. Partially drafted in the docs (in pieces), though not actually tested in real cluster. Waiting for the missing feature of the silent spies.


Since then, the framework is sufficiently feature-rich for the first stage (it is now, actually, just the docs do not feel complete), and can be advertised in public: meetups, blog posts, so on.

Based on the real-world feedback, the next milestones can be defined.

The real-world usage is the most important goal now. I.e., getting the operators implemented with this framework (and preferably shared).

Meanwhile, I write down all the ideas that come to my mind as the issues. If you have some suggestions, feel free to create the issues too. Examples: #44, #45, #46.

@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] [GH-33] implement auto detection mode for peering. Aug 19, 2020
@kopf-archiver kopf-archiver bot added the enhancement New feature or request label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

0 participants