Convert internal timestamps to TZ-aware, treat user-provided TZ-naive ones as UTC #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nolar
force-pushed
the
tz-aware-timestamps
branch
from
54d4f9b
to
b1b59b1
Compare
…etime Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
… ones as UTC The old TZ-naive way is deprecated in Python 3.12 and soon will be removed. Switch to TZ-aware time for "now", and for all places that compare against "now". Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
nolar
force-pushed
the
tz-aware-timestamps
branch
from
b1b59b1
to
dddaa5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few places inside Kopf were using TZ-naive timestamps internally:
Since
datetime.datetime.utcnow()is deprecated in Python 3.12, we have to switch to TZ-aware "now" timestamps, and convert the rest for the ability to compare (Python cannot compare TZ-aware to TZ-naive).This PR ensures that all internal timestamps are TZ-aware. All user-provided TZ-naive timestamps are treated as UTC for comparison (but stored "as is").
The timestamps provided by Kubernetes API & Kubernetes resources were always parsed as TZ-aware, so this should not cause any spike in K8s API activity for reformatting the timestamps. And even if hypothetically happens to do that, this change only applies to Kopf's own "progression" timestamps, so this only affects the handlers that are still in progress/retrying, not the final stable state of resources.