Reunite the watch-streaming-freezing coroutines #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ec2c152, a simple streaming coroutine has been split to monitor for freeze flags/modes on the streaming itself (before that, the stream was always on, but the events were ignored). Now, that freeze controlling logic requires much more sophistication, so it is extracted into a separate context manager, while the streaming routines are re-united back: * one for the infinite watch — until the operator exits or the resource becomes out of scope (the latter is not yet done); * one for the continuous watch: one initial listing + multiple streams — as long as the resource version is valid; * and one for a single watch (a single API call). This also simplifies the tests for freezing/resuming of the streams — no mocked streams are needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ec2c152, a simple streaming coroutine has been split to monitor for freeze flags/modes on the streaming itself (before that, the stream was always on, but the events were ignored). Now, that freeze controlling logic requires much more sophistication, so it is extracted into a separate context manager, while the streaming routines are re-united back:
This also simplifies the tests for freezing/resuming of the streams — no mocked streams are needed anymore.
Relies on #608.