Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discovery: check resources of api_version exist #615

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

amadev
Copy link
Contributor

@amadev amadev commented Dec 15, 2020

What do these changes do?

This change adds an additional check that resource exists in context._discovered_resources.

Description

Detailed info in the issue.

Issues/PRs

issue: #613

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

@amadev amadev requested a review from nolar as a code owner December 15, 2020 09:52
@nolar nolar merged commit 1e517d0 into nolar:release/0.28 Dec 15, 2020
@nolar
Copy link
Owner

nolar commented Dec 15, 2020

The tests were failing for the example 10 — a known issue. It was fixed in 0.28.x in #619 (back-ported from the main branch from #608). The failure is not related to this PR, so it should be fine. I have double-checked in a follow-up PR #618 — the tests are fine with both these PRs merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants