Drop Kubernetes 1.14 #723
Merged
Drop Kubernetes 1.14 #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trigger of change is that it fails with admission requests in Kubernetes <1.15 (1.14 is the latest supported by Kopf), with v1beta1 admission reviews, with DELETE operations — the "object" is NULL there. It would require significant complexity on our side with remembering and recalling the object bodies in memory (which we have for daemons/timers anyway, but not for admissions). Kubernetes 1.14 was released March 2019 (2 years ago). The usual support policy by Kubernetes is 1 year (https://kubernetes.io/docs/setup/release/version-skew-policy/). AWS supports Kubernetes 1.15+ (https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html). GCP supports Kubernetes 1.15+ (https://cloud.google.com/kuberun/docs/cluster-versions). In practice, new clusters are 1.16+ in the "stable" channel. There is no reason for Kopf to support 1.14 anymore. New versions of Kopf will most likely continue working with old features — except for the new admission hooks — but are not tested against 1.14. If needed, pin Kopf's version to the one that worked (1.30.x). Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trigger of change is that it fails with admission requests in Kubernetes <1.15 (1.14 is the latest supported by Kopf), with v1beta1 admission reviews, with DELETE operations — the "object" is NULL there. It would require significant complexity on our side with remembering and recalling the object bodies in memory (which we have for daemons/timers anyway, but not for admissions).
Kubernetes 1.14 was released March 2019 (2 years ago). The usual support policy by Kubernetes is 1 year (https://kubernetes.io/docs/setup/release/version-skew-policy/).
AWS supports Kubernetes 1.15+ (https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html).
GCP supports Kubernetes 1.15+ (https://cloud.google.com/kuberun/docs/cluster-versions). In practice, new clusters are 1.16+ in the "stable" channel.
There is no reason for Kopf to support 1.14 anymore. New versions of Kopf will most likely continue working with old features — except for the new admission hooks — but are not tested against 1.14. If needed, pin Kopf's version to the one that worked (1.30.x).