Handle connection errors during list_obj calls gracefully #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Sontag <philipp.sontag@blueyonder.com>
psontag
force-pushed
the
handle-list-objs-errors
branch
from
98f1e7e
to
dfbfae5
Compare
The reason will be logged several log lines above — when the API retrying fails with an exception. The restart is better to be silent on errors in listing — the same way as it is silent on errors in streaming.
|
I've made several corrections regarding logging: to not log the reason of the stream restart — the same as it happens when the streaming API call fails, for consistency. The error is not silenced anyway — the API retrying routines will complain about the error as needed. |
|
Hey @nolar thanks for merging the PR 👍 . |
|
@philipp-sontag-by I can make an RC this weekend — I just want to run through all issues and see if anything else is easily doable — to release all the quick fixes at once (while trying to catch the joy of the last days of warm & sunny weather). |
|
Ok, no worries take your well earned time off 👍 |
|
Pre-released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should catch any errors that occur during the initial listing of the objects, even those that make it through the retries.
The listing should then be retried automatically like usual when the continuous watch ends.
I am not sure if this is the best way to fix this. I am not that familiar with the code base yet. So if you have any recommendations here let me know.
closes: #787