Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(git-changelog): include extensions option #175

Merged
merged 6 commits into from Apr 17, 2024
Merged

feat(git-changelog): include extensions option #175

merged 6 commits into from Apr 17, 2024

Conversation

kwaa
Copy link
Contributor

@kwaa kwaa commented Apr 17, 2024

closed #168

nekomeowww
nekomeowww previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@nekomeowww nekomeowww enabled auto-merge (squash) April 17, 2024 08:47
@nekomeowww nekomeowww added the enhancement New feature or request label Apr 17, 2024
@nekomeowww nekomeowww added this to the 2.0.0 milestone Apr 17, 2024
@nekomeowww
Copy link
Member

Would you like to write tests for your feature?

Simply bootstrap a Vitest daemon with nr test or pnpm test and test the functionalities under either helpers.test.ts.
If not, may I ask to to move the following part

https://github.com/nolebase/integrations/pull/175/files#diff-fcb2092920a76827b7bd7def5b8c0b58266895e09a8032437e0228f10eb8a608R81-R84

under helpers.ts therefore I can finished the tests later?

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://661fa031ccc8a59d052cee91--nolebase-integrations.netlify.app
Windows Success https://661fa03c9005a614160c5fab--nolebase-integrations.netlify.app

@kwaa
Copy link
Contributor Author

kwaa commented Apr 17, 2024 •
edited

If move to helpers.ts, maybe it should be named generateRegExp?

@nekomeowww
Copy link
Member

@kwaa How about generateCommitPathsRegExp?

@kwaa
Copy link
Contributor Author

kwaa commented Apr 17, 2024

I tried to add some tests.

@kwaa kwaa requested a review from nekomeowww April 17, 2024 09:41
@nekomeowww
Copy link
Member

Else LGTM.

nekomeowww
nekomeowww previously approved these changes Apr 17, 2024
View reviewed changes
@nekomeowww nekomeowww enabled auto-merge (squash) April 17, 2024 09:51
auto-merge was automatically disabled April 17, 2024 09:55

Head branch was pushed to by a user without write access

@kwaa
Copy link
Contributor Author

kwaa commented Apr 17, 2024

Hmm... style/arrow-parens is a bit weird.

It should work now.

@kwaa
Copy link
Contributor Author

kwaa commented Apr 17, 2024

Maybe you need to re-enable auto-merge?

@nekomeowww nekomeowww merged commit 1c7d970 into nolebase:main Apr 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekomeowww nekomeowww nekomeowww approved these changes

Assignees

@kwaa kwaa

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

improve(git-changelog): allow more extensions
2 participants
@kwaa @nekomeowww