Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(og image): enhanced configuration, image URL support #253

Merged
merged 12 commits into from
Jul 12, 2024
Merged

feat(og image): enhanced configuration, image URL support #253

merged 12 commits into from
Jul 12, 2024

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Jul 12, 2024 •
edited
Loading

I've made some changes to the @nolebase/vitepress-plugin-og-image package to improve its stability and add missing features that I needed in my project.

  • Fixed an issue where documents from the sidebar were not resolved like how Vitepress resolves them
  • Added support for rendering images inside the SVG template
  • Added support for passing custom font buffers
  • Added configuration option to specify a custom SVG template path
  • Improved the line splitting algorithms to attempt to split by spaces or capital letters (useful for camelCase text)
  • Made sure that an og:image meta tag is not added if it already exists in the HTML

nekomeowww
nekomeowww previously approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://6690b244bd7c20b253422da2--nolebase-integrations.netlify.app
Windows Success https://6690b24fe3460ebf0a58979b--nolebase-integrations.netlify.app

@nekomeowww nekomeowww merged commit c2fb0c0 into nolebase:main Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekomeowww nekomeowww nekomeowww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giladgd @nekomeowww