Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amended touch support test as it was returning true on none-touch windows devices #3395

Closed
wants to merge 2 commits into from

Conversation

hamzahg
Copy link

@hamzahg hamzahg commented Jan 9, 2020

This change is based on the following open issue:

#3232

I have come across the same issue in my project and have amended the script as per the PR, which has resolved the issues on MS Edge and Chrome on Windows based devices.

…dows browsers and breaking scrollbar drag behaviour
@nolimits4web
Copy link
Owner

This fix is wrong, where did window.DocumentTouch && document instanceof window.DocumentTouch go? There is no navigator.MaxTouchPoints property

@Jollus174
Copy link

#3401
I'd recommend simply reverting commit df41dc94c9d9224fcbeb0166e6a5a9634caa6f1d.
This will check to see if the device has touch-capabilities, which will impact the slider.
maxTouchPoints will test to see if the device supports touch, which is ambiguous since what if the user is using a laptop or desktop with a touch screen.

@hirbod
Copy link

hirbod commented May 7, 2020

@stale
Copy link

stale bot commented Nov 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 5, 2020
@stale
Copy link

stale bot commented Jan 4, 2021

This issue has been automatically closed due to inactivity. If this issue is still actual, please, create the new one.

@stale stale bot closed this Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants