Adding typings file to fix #3916 #4138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This initial typings file will allow the package to be used with Vue Typescript projects and use the Swiper and SwiperSlide as components.
|
Is it compatible with Vue.js v3 ? |
|
Yeah should be because it doesn't really care what version the NPM Vue library is. Does swiper's Vue library support v3 though? The api for components has changed significantly and its not backwards compatible. |
|
Swiper compatible ONLY with Vue 3 https://swiperjs.com/vue. Seems like these typings are not valid for Vue 3, because Vue 3 doesn't have default export |
|
I use this typings file with Vue 2 so Swiper is compatible with Vue 2. Let me do some investigating and see how I can make it work for both. |
|
@GerryWilko hey, any updates? |
|
types added here #4707. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial typings file will allow the package to be used with Vue Typescript projects and use the Swiper and SwiperSlide as components.
Fixes #3916