Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make starter html layout optional #4507

Merged
merged 14 commits into from
May 24, 2021

Conversation

vltansky
Copy link
Collaborator

@vltansky vltansky commented May 1, 2021

    <section class="swiper-container">
      <div class="swiper-slide">Slide 1</div>
      <div class="swiper-slide">Slide 2</div>
      <div class="swiper-slide">Slide 3</div>
      <div class="swiper-slide">Slide 4</div>
      <div class="swiper-slide">Slide 5</div>
      <div class="swiper-slide">Slide 6</div>
      <div class="swiper-slide">Slide 7</div>
      <div class="swiper-slide">Slide 8</div>
      <div class="swiper-slide">Slide 9</div>
      <div class="swiper-slide">Slide 10</div>
    </section>

The downside is probably CLS. But we can recommend to use full structure for better performance?

Not sure if it should target v7 branch or just master?

@vltansky vltansky requested a review from nolimits4web May 1, 2021 18:20
src/components/core/core-class.js Outdated Show resolved Hide resolved
src/components/navigation/navigation.js Outdated Show resolved Hide resolved
src/components/pagination/pagination.js Outdated Show resolved Hide resolved
src/components/scrollbar/scrollbar.js Outdated Show resolved Hide resolved
src/utils/utils.js Outdated Show resolved Hide resolved
@nolimits4web nolimits4web marked this pull request as ready for review May 24, 2021 14:46
@nolimits4web nolimits4web merged commit aef2865 into nolimits4web:master May 24, 2021
@@ -444,10 +444,10 @@ interface Swiper extends SwiperClass<SwiperEvents> {
keyboard: KeyboardMethods;
lazy: LazyMethods;
mousewheel: MousewheelMethods;
navigation: NavigationMethods;
pagination: PaginationMethods;
navigation: NavigationMethods | boolean;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone uses TypeScript and used navigation methods in that way: swiper.navigation.update();. TypeScript will raise a error: "Property 'update' does not exist on type boolean | NavigationMethods"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants