Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with package distribution metadata set for package version. #77

Closed
atomey opened this issue Apr 10, 2023 · 1 comment
Closed

Issue with package distribution metadata set for package version. #77

atomey opened this issue Apr 10, 2023 · 1 comment
Labels

Comments

@atomey
Copy link

atomey commented Apr 10, 2023

I'm having an issue with using this package in a virtual environment in Python 3.11. I noticed the pkg_resources call to pull the versioning when msoffcrypto-tool runs the init.py is wrong.

It seems this should now be done using the importlib_metadata, which is included since Python 3.8. I've updated the module locally to import with this method and now do not get any distribution errors:

try:
    import importlib_metadata
except ImportError:
    import importlib.metadata as importlib_metadata

__version__ = importlib_metadata.version("msoffcrypto-tool")

Confirmed here https://setuptools.pypa.io/en/latest/pkg_resources.html, pkg_resources is deprecated.

@nolze
Copy link
Owner

nolze commented Jul 17, 2023

Fixed in v5.1.0. Thank you for reporting!

@nolze nolze closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants