Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dither implementation to use ZDITHER0 #377

Closed
attipaci opened this issue Mar 8, 2023 · 0 comments · Fixed by #380
Closed

Dither implementation to use ZDITHER0 #377

attipaci opened this issue Mar 8, 2023 · 0 comments · Fixed by #380
Assignees
@attipaci
Labels
enhancement A new feature and/or an improved capability standard Improved compliance to FITS standard
Milestone
1.18.0

Comments

@attipaci
Copy link
Collaborator

attipaci commented Mar 8, 2023 •
edited

Currently the library does not used the ZDITHER0 keyword. The purpose of that header keyword is to record the random seed that was used for compression so the same random sequence might also be used in the decompression. Currently the library neither generates that keyword when using dither to compress, nor does it use that keyword to seed the random generator when decompressing (via QuantizeOption.setSeed(long)).

Related to #349.

Tagging @keastrid also.
@attipaci attipaci added enhancement A new feature and/or an improved capability standard Improved compliance to FITS standard labels Mar 8, 2023
@attipaci attipaci added this to the 1.18.0 milestone Mar 8, 2023
@attipaci attipaci self-assigned this Mar 8, 2023
@attipaci attipaci linked a pull request Mar 16, 2023 that will close this issue
Use ZDITHER0 and seed dither random generator for each tile as prescribed #380
Merged
@attipaci attipaci pinned this issue Mar 16, 2023
@attipaci attipaci unpinned this issue Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@attipaci attipaci

Labels
enhancement A new feature and/or an improved capability standard Improved compliance to FITS standard
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

Use ZDITHER0 and seed dither random generator for each tile as prescribed attipaci/nom-tam-fits
1 participant
@attipaci