Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 371: Improved documentation of Fits constructors #372

Merged
merged 9 commits into from Mar 6, 2023

Conversation

attipaci
Copy link
Collaborator

@attipaci attipaci commented Mar 1, 2023

Improved documentation of Fits constructors.

dependabot bot and others added 9 commits September 12, 2022 20:29
Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.7.1.1 to 4.7.2.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.7.1.1...spotbugs-maven-plugin-4.7.2.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…bugs-spotbugs-maven-plugin-4.7.2.0

build(deps): bump spotbugs-maven-plugin from 4.7.1.1 to 4.7.2.0
Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.18.0 to 3.19.0.
- [Release notes](https://github.com/apache/maven-pmd-plugin/releases)
- [Commits](apache/maven-pmd-plugin@maven-pmd-plugin-3.18.0...maven-pmd-plugin-3.19.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-pmd-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@attipaci attipaci added the package Issues with the packaging label Mar 1, 2023
@attipaci attipaci added this to the 1.17.1 milestone Mar 1, 2023
@attipaci attipaci self-assigned this Mar 1, 2023
@attipaci attipaci linked an issue Mar 1, 2023 that may be closed by this pull request
@attipaci attipaci changed the title Issue 371 Issue 371: Improved documentation of Fits constructors Mar 1, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #372 (ec585bf) into master (f2d07f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #372   +/-   ##
=========================================
  Coverage     96.74%   96.75%           
  Complexity     4153     4153           
=========================================
  Files           194      194           
  Lines         12246    12247    +1     
  Branches       1763     1763           
=========================================
+ Hits          11848    11849    +1     
  Misses          163      163           
  Partials        235      235           
Flag Coverage Δ
unittests 96.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/nom/tam/fits/Fits.java 96.49% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2d07f1...ec585bf. Read the comment docs.

@attipaci attipaci merged commit 87eb9c7 into nom-tam-fits:master Mar 6, 2023
@attipaci attipaci deleted the issue-371 branch March 6, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package Issues with the packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fits::write() saves only HDUs loaded in memory
2 participants