Use Exiv2::CommentValue to format Exif.Photo.UserComment metadatum #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @pinotree , |
Converting the UserComment exif metadatum to string will result in its direct/quasi-internal string representation of libexiv2, which may include a "charset=..." prefix with the charset of the value. Since we want the actual content/value of UserComment, and the Exiv2::Value held by Exiv2::Exifdatum is Exiv2::CommentValue, then cast it to call comment(). The result is converted to QString using QString::fromStdString(), which converts std::string as UTF-8 string. For further details, see also the exiv2 ticket: Exiv2/exiv2#1258 Signed-off-by: Pino Toscano <toscano.pino@tiscali.it>
pinotree
force-pushed
the
exif-comment-formatting
branch
from
66f4015
to
8eba3dc
Compare
Not sure what you are looking for exactly: if it's about potentially asking questions later on, sure, there is no problem; long time maintainership, not really, as I'm not an user of nomacs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the UserComment exif metadatum to string will result in its direct/quasi-internal string representation of libexiv2, which may include a
charset=...prefix with the charset of the value.Since we want the actual content/value of
UserComment, and theExiv2::Valueheld byExiv2::ExifdatumisExiv2::CommentValue, then cast it to callcomment(). The result is converted toQStringusingQString::fromStdString(), which converts std::string as UTF-8 string.For further details, see also the exiv2 ticket:
Exiv2/exiv2#1258