Skip to content
This repository has been archived by the owner on Jun 20, 2021. It is now read-only.

Build command: update Xcode version validation for Xcode 10+ (#351) #352

Merged
merged 2 commits into from
Sep 29, 2018
Merged

Build command: update Xcode version validation for Xcode 10+ (#351) #352

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1b8fab
Build command: update Xcode version validation for Xcode 10+ (#351)
thzinc Sep 21, 2018
bf8944e
Fixed variable naming to match convention
thzinc Sep 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/shenzhen/commands/build.rb
View file
Open in desktop
Expand Up @@ -150,7 +150,8 @@

def validate_xcode_version!
version = Shenzhen::XcodeBuild.version
say_error "Shenzhen requires Xcode 4 (found #{version}). Please install or switch to the latest Xcode." and abort if version < "4.0.0"
majorVersion = version.split('.')[0].to_i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the naming? It must be consistent with the project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, sure thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the requested change. Thanks for your feedback!

say_error "Shenzhen requires Xcode 4 (found #{version}). Please install or switch to the latest Xcode." and abort if majorVersion < 4
end

def determine_workspace_or_project!
Expand Down