-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch configs in configuration package build script #173
Conversation
d26fe3f
to
9ddb435
Compare
Ok given the current setup, iiuc an agent will always take the latest config from github pages. If we do not want to include the latest github pages updates, we can鈥檛 actually do anything about it because build will always fetch latest. Clarification on full workflow here and documented in code? :) |
abc805f
to
ec807df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concluded that lack of flexibility around versions is not problem here. Deploys use pre-deploy folder. GUI shouldn't come before agents
Automatically fetch latest configs from github when building the configs package
Limitations
This may hamper our ability to iterate on configuration layout, as the build.rs will pull in the github version. Can we have some sort of flag to disable the build.rs? 馃
Conversely, limiting our ability to bork the existing canonical configs is probably a good thing :)
Motivation
Stop having to manually edit configs in this package, allow agents to fetch configs from a canonical source instead of relying on built-in configs
Solution
PR Checklist