Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch configs in configuration package build script #173

Merged
merged 12 commits into from
Jul 1, 2022

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented May 17, 2022

Automatically fetch latest configs from github when building the configs package

Limitations

This may hamper our ability to iterate on configuration layout, as the build.rs will pull in the github version. Can we have some sort of flag to disable the build.rs? 馃

Conversely, limiting our ability to bork the existing canonical configs is probably a good thing :)

Motivation

Stop having to manually edit configs in this package, allow agents to fetch configs from a canonical source instead of relying on built-in configs

Solution

  • build.rs fetches latest development + production + staging configs from github pages
  • if the config cannot be fetched, it will be ignored by build.rs. This means past versions in the configs folder will be used
  • crate build will fail if a fetched version is unavailable and there is no past version in the folder

PR Checklist

  • Added Tests
  • Updated Documentation
  • Updated CHANGELOG.md for the appropriate package

@prestwich prestwich self-assigned this May 18, 2022
@prestwich prestwich added the enhancement New feature or request label May 18, 2022
@prestwich prestwich changed the title Prestwich/fetch configs Fetch configs in configuration package build script May 18, 2022
@prestwich prestwich force-pushed the prestwich/fetch-configs branch 2 times, most recently from d26fe3f to 9ddb435 Compare June 10, 2022 19:13
@luketchang
Copy link
Collaborator

luketchang commented Jun 30, 2022

Ok given the current setup, iiuc an agent will always take the latest config from github pages. If we do not want to include the latest github pages updates, we can鈥檛 actually do anything about it because build will always fetch latest. Clarification on full workflow here and documented in code? :)

Copy link
Collaborator

@luketchang luketchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concluded that lack of flexibility around versions is not problem here. Deploys use pre-deploy folder. GUI shouldn't come before agents

@prestwich prestwich merged commit b2206e2 into main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants