fix(config): lower per-message gas hardcode #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Imti what are your format settings? We keep getting settings conflicts |
prestwich
reviewed
Jun 17, 2022
| @@ -1,29 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
should be in the config repo?
…per message hardcode for home:update
prestwich
force-pushed
the
luke/remove-gas-defaults
branch
from
89841c3
to
c8fb7b4
Compare
prestwich
force-pushed
the
luke/remove-gas-defaults
branch
from
c8fb7b4
to
6ba5b77
Compare
prestwich
changed the title
prestwich
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Gas estimate hardcodes generally a bit high. Causes extremely high estimates for devnets due to high number of messages being constantly enqueued.
Solution
Remove evmDefault hardcodes where not necessary (only needed on Moonbeam, Milkomeda, and xDai given past history). Also lower per-message gas hardcode for home:update.
PR Checklist