refactor: remove deprecated deploy configuration keys #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
force-pushed
the
prestwich/remove-deploy-gas
branch
from
89382b9
to
065ccbb
Compare
luketchang
reviewed
Jul 18, 2022
prestwich
force-pushed
the
prestwich/remove-deploy-gas
branch
2 times, most recently
from
64ffc38
to
1b3e3b4
Compare
prestwich
force-pushed
the
prestwich/remove-deploy-gas
branch
from
1b3e3b4
to
ced413f
Compare
lattejed
approved these changes
Jul 26, 2022
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ### Unreleased | |||
|
|
|||
| - feature: add more explicit Processor Config TS declaration | |||
| - refactor: make Processor config keys optional, and prevent trivial ser. | |||
There was a problem hiding this comment.
oh I mean serialization. changed it to be more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As of 1.1.0, the protcol is no longer gas-aware. We have removed these keys from the deployment process, and should remove them from the config types
Solution
PR Checklist
followup