-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add untested/unintegrated nomad-substrate
crate
#231
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bstrateHome barring type issues
…e before reworking ChainCommunicationError
…tead of ChainCommunciationError, rest of build failing
…ionError with chain specific enum moved to nomad-base
…er index updates with attached method
…and unwraps mostly removed
…onversion as util not macro
nomad-substrate
nomad-substrate
crate
…er stubs for v2 of substrate integration
Closing in favor of #232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enable Nomad agents to run against substrate chains. Must add
nomad-substrate
crate to implement contract traits.Solution
Major High Level Changes
nomad-substrate
crate torust/chains
but does NOT integrate into rest of codebase (i.e.nomad-base
andagents
)nomad_core::ChainCommunicationError
tonomad-base
and makes it a wrapper across chain-specific error types defined in `chainsnomad-core
nomad-base
draw on chain-specific crates and serve as chain-agnostic wrappernomad_core::{Common, Home, ConnectionManager}
to return associated type error (Self::Error
), having chain-specific crates define/return their own chain-specific error types (e.g.EthereumError
,SubstrateError
)Details
nomad-substrate
SubstrateHome
andSubstrateHomeIndexer
objects and implements necessarynomad_core
traitsSubstrateError
type which wraps all subxt and scale-value deserialization errors (substrate-specific)nomad-core
ChainCommunicationError
(changed/moved tonomad-base
)ChainCommunicationError
nomad-base
ChainCommunicationError
which wrapsnomad_ethereum::EthereumError
andnomad_substrate::SubstrateError
nomad-ethereum
EthereumError
error enum to wrapper ethers and gelato errors (ethereum-specific)Results<_, EthereumError>
now instead of using oldChainCommunicationError
accumulator
LightMerkle
(nomad-substrate
needs this to decode tree object)PR Checklist