This repository has been archived by the owner on Jun 20, 2021. It is now read-only.
Build command: update Xcode version validation for Xcode 10+ (#351) #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi All, when this Pull Request will merge? |
dankimio
suggested changes
Sep 27, 2018
lib/shenzhen/commands/build.rb
Outdated
| @@ -150,7 +150,8 @@ | |||
|
|
|||
| def validate_xcode_version! | |||
| version = Shenzhen::XcodeBuild.version | |||
| say_error "Shenzhen requires Xcode 4 (found #{version}). Please install or switch to the latest Xcode." and abort if version < "4.0.0" | |||
| majorVersion = version.split('.')[0].to_i | |||
There was a problem hiding this comment.
Can you fix the naming? It must be consistent with the project.
There was a problem hiding this comment.
I've made the requested change. Thanks for your feedback!
dankimio
approved these changes
Sep 29, 2018
|
@thzinc Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not see a contributor's guide, so please let me know if there are any changes needed to this work.
Thanks!