Update for iOS 7 style receipts #21
Conversation
|
fwiw, looks good to me |
|
Realized just today there's a bit more work to do on the binary file, or at very least on the readme that describes it. |
|
Hi @amoslanka, Apologies for the delay. I should be able to review this in the next day or two. |
|
@mattt looking at this stuff more in the last week, I realize iTunes will validate both new and old style receipts. Since old style receipts are still out in the wild and would potentially be verified, handling of those receipts and switching parsers after receiving the response from iTunes would be necessary. Currently this PR only expects to handle the new style. Is it your goal for Venice to support both? |
That is my goal, yes. This is the main reason for delay in merging this. Still reviewing to determine the best course of action. |
|
That makes sense. I'm happy to contribute towards the course you have in mind. |
|
Really hanging out for something along these lines. I'd also happily help out. |
Fix hash fields for in app receipt
|
Hi guys. Any plans to move it forward with iOS6 backward compatibility? |
|
@mattt @amoslanka Also curious about @morgoth's comment! |
|
Surely at this point, support for iOS 7 receipts exceeds the need for iOS6 support. If backwards compatibility is a requirement, then I'll look into adding it if that is what it takes to get something like this merged in. |
|
Merging this and dropping iOS 6 support for the next release. Thanks all! |
Update for iOS 7 style receipts
There are previous PR's for iOS 7 receipts, and some questions still remain. I personally have two projects that require a quality implementation so I'd love to contribute whatever is lacking.
I'd like some insight on backwards compatibility. With these updates would Venice push to a significant version bump?
I don't think spec coverage is near complete in this implementation but the baseline is there as is fixes for specs that were broken immediately when forked.
This PR includes @coneybeare's commits from February.