Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to set sidebar as folded by default in narrow mode #10

Closed
GJRobert opened this issue Sep 16, 2020 · 7 comments
Closed

Option to set sidebar as folded by default in narrow mode #10

GJRobert opened this issue Sep 16, 2020 · 7 comments
Assignees
@nomadjimbob
Labels
Category: Feature The issue describes a feature request Priority: Medium

Comments

@GJRobert
Copy link
Contributor

I prefer to fold/hide the sidebar in responsive narrow views when the page is first loaded, and let the user to unfold it if necessary.

Is it possible to set a toggle in the conf?
@nomadjimbob nomadjimbob self-assigned this Sep 16, 2020
@nomadjimbob nomadjimbob added Category: Feature The issue describes a feature request Priority: Medium labels Sep 16, 2020
@nomadjimbob
Copy link
Owner

I'll add this feature for collapsable the left and right sidebars when in desktop mode in the next release.

@GJRobert
Copy link
Contributor Author

I'll add this feature for collapsable the left and right sidebars when in desktop mode in the next release.

Hi,
in case I might have expressed myself wrong,

Actually I just hope to collapse the sidebars in the mobile (narrow) mode by default (when the page is loaded)

Since presently, the sidebar (I am only using the left one, not yet tested the right one) is fully displayed in the mobile mode by default like this:
2020-09-17_13-54-04

I hope to let readers to see the page content more instantly when the page loads, so that we can save the click on the "Sidebar" toggle. 👍

So I am okay with the present behavior of sidebars in the desktop (wide) mode (not collapsible but not my concern)

@GJRobert GJRobert changed the title Option to set sidebar as folded by default Option to set sidebar as folded by default in narrow mode Sep 17, 2020
@GJRobert
Copy link
Contributor Author

I just updated the title of this issue. Sorry for the under-expression. (not clarifying enough)

@nomadjimbob
Copy link
Owner

Oh ok. sorry for the misunderstanding. As an example in the mikio.php file if you change the text on line 670 from class="mikio-sidebar-toggle" to class="mikio-sidebar-toggle closed", does that have the desired affect?

@GJRobert
Copy link
Contributor Author

Oh ok. sorry for the misunderstanding. As an example in the mikio.php file if you change the text on line 670 from class="mikio-sidebar-toggle" to class="mikio-sidebar-toggle closed", does that have the desired affect?

Oh that's great! Exactly what I need! Thanks for that tip!

@nomadjimbob
Copy link
Owner

Oh ok. sorry for the misunderstanding. As an example in the mikio.php file if you change the text on line 670 from class="mikio-sidebar-toggle" to class="mikio-sidebar-toggle closed", does that have the desired affect?

Oh that's great! Exactly what I need! Thanks for that tip!

Cool. I believe that should be the default for the theme. I'll add it into the next release as the default with the reverse option in config to not hide the sidebar on mobile by default

nomadjimbob added a commit that referenced this issue Sep 26, 2020
@nomadjimbob
Sidebars hidden by default in mobile view #10
d31c461
@nomadjimbob
Copy link
Owner

Option added to release 2020-09-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nomadjimbob nomadjimbob

Labels
Category: Feature The issue describes a feature request Priority: Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GJRobert @nomadjimbob